Updates for 5922 - Staff can send Group messages #5957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smithellis
commented
Apr 16, 2024
- Fixes privelege escalation - 1721
- Fixes bolded message text - 1726
- Removes unneeded Avatars - 1724
- Don't show a To if there is no To - 1723
- Attempts to resolve 502 issue - 1720
This was referenced Apr 16, 2024
AcharayuAiyara
approved these changes
Apr 16, 2024
escattone
requested changes
Apr 16, 2024
escattone
reviewed
Apr 16, 2024
* Fixes privelege escalation - 1721 * Fixes bolded message text - 1726 * Removes unneeded Avatars - 1724 * Don't show a To if there is no To - 1723 * Attempts to resolve 502 issue - 1720
879d99e to
b161aa0
Compare
escattone
approved these changes
Apr 16, 2024
| set_of_user_pks_to_email_private_message = set( | ||
| Setting.objects.filter( | ||
| user__in=receivers, name="email_private_messages", value=True | ||
| ).values_list("user__pk", flat=True) |
There was a problem hiding this comment.
Just for the sake of knowledge sharing, .values_list("user", flat=True) is equivalent to .values_list("user__pk", flat=True).
There was a problem hiding this comment.
Ah - yes, I left that when troubleshooting why this was failing. It was the value=True bit that was missing.
There was a problem hiding this comment.
Good catch on the value=True!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.